doc: add guide and answers to FAQs for first-time contributors#63685
Conversation
|
Review requested:
|
nodejs-github-bot
added
doc
joyeecheung
force-pushed
the
first-time
branch
2 times, most recently
from
bfc12f2 to
5a9bf7c
Compare
|
Seemingly one of the more common tropes at the moment is opening PRs against issues with an existing open PR. I couldn't see any specific mention of this in our existing guidance, but this seems like a good place to discourage it. |
|
As a new contributor I was confused by not being able to access Jenkins logs and I thought I must be missing some privileges. As I later found out, that was due to being locked out because a security release was being prepared. Perhaps that should be mentioned somewhere? Maybe not just in the FAQs for first-time contributors, but also in the regular PR submission guidelines? |
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
|
@aduh95 @LiviaMedeiros @MikeMcC399 @trivikr @MoLow I think I addressed all the comments. Can you take a look again? Thanks! |
Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
|
Going to land this by the end of today if there is no blocking concerns. |
joyeecheung
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 457fa67 |
9 participants
This guide tries to capture some recurring issues I see (with suggestions that other collaborators seem to agree with in offline discussions) and address FAQs I constantly get when mentoring different new contributors.